Add dry-run to labelanalysis #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 95.46% 95.49% +0.02%
==========================================
Files 69 69
Lines 2427 2443 +16
==========================================
+ Hits 2317 2333 +16
Misses 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This change comes as a request of sentry infra team to increaase our chances of merging ATS into getsentry initially. The `--dry-run` option simply stops label analysis after collecting labels and prints them in the terminal. Yes, there are other ways that you can achieve the same result (e.g. custom runner), but this is more straight forward. It might be marginally useful when setting up or building confidence of label analysis for customers interested in the feature, so why not? I decided to add a brief explanation to what each label group is, since we have that opportunity here.
giovanni-guidini
force-pushed
the
gio/dry-run-labelanalysis
branch
from
bad7bc9
to
fa94034
Compare
dana-yaish
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change comes as a request of sentry infra team to increaase our chances of merging ATS into getsentry initially.
The
--dry-runoption simply stops label analysis after collecting labels and prints them in the terminal. Yes, there areother ways that you can achieve the same result (e.g. custom runner), but this is more straight forward.
It might be marginally useful when setting up or building confidence of label analysis for customers interested in the feature,
so why not?
I decided to add a brief explanation to what each label group is, since we have that opportunity here.